Thread (20 messages) 20 messages, 6 authors, 2025-06-21

Re: [PATCH net-next 10/10] net: ethtool: don't mux RXFH via rxnfc callbacks

From: Simon Horman <horms@kernel.org>
Date: 2025-06-20 09:50:18

On Wed, Jun 18, 2025 at 01:38:23PM -0700, Jakub Kicinski wrote:
All drivers have been converted. Stop using the rxnfc fallbacks
for Rx Flow Hashing configuration.

Joe pointed out in earlier review that in ethtool_set_rxfh()
we need both .get_rxnfc and .get_rxfh_fields, because we need
both the ring count and flow hashing (because we call
ethtool_check_flow_types()). IOW the existing check added
for transitioning drivers was buggy.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help