On 6/18/25 6:08 AM, Jason Wang wrote:

On Wed, Jun 18, 2025 at 12:13 AM Paolo Abeni [off-list ref] wrote:

quoted

+/*
+ * vlan_hlen always refers to the outermost MAC header. That also
+ * means it refers to the only MAC header, if the packet does not carry
+ * any encapsulation.
+ */
+static inline int
+virtio_net_hdr_tnl_from_skb(const struct sk_buff *skb,
+                           struct virtio_net_hdr_v1_hash_tunnel *vhdr,
+                           bool tnl_hdr_negotiated,
+                           bool little_endian,

Nit: it looks to me we can just accept netdev_features_t here.

That will replace a single bool argument with a netdev_features_t, right?

I guess we can do that when it will allow reducing the arguments number.

Thanks,

Paolo