Re: [PATCH net-next 3/3] eth: sfc: migrate to new RXFH callbacks

On 17/06/2025 02:39, Jakub Kicinski wrote:

Migrate to new callbacks added by commit 9bb00786fc61 ("net: ethtool:
add dedicated callbacks for getting and setting rxfh fields").

This driver's RXFH config is read only / fixed so the conversion
is purely factoring out the handling into a helper. One thing of
note that this is one of the two drivers which pays attention to
rss_context.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>

Although,

+int efx_ethtool_get_rxfh_fields(struct net_device *net_dev,
+				struct ethtool_rxfh_fields *info)
+{
+	struct efx_nic *efx = efx_netdev_priv(net_dev);
+	struct efx_rss_context_priv *ctx;
+	__u64 data;
+	s32 rc = 0;

this could just be an int; it's only an s32 in efx_ethtool_get_rxnfc()
for the sake of the ETHTOOL_GRXCLSRLALL path which uses it for more
than just 0/negative error.  Up to you whether to change and respin.