On 13/06/2025 15:50, Jakub Kicinski wrote:
On Fri, 13 Jun 2025 14:44:40 +0100 Edward Cree wrote:
quoted
So granted that you're only moving code, but looking at this it doesn't
actually make sense, since every path that sets info->data to nonzero
also sets min_revision, so why not just do the ef4_nic_rev() check at
the start? Answer, from git log spelunking, is that when this code was
shared with Siena, EFX_REV_SIENA_A0 supported IPv6 here.
Ack, I was tempted to clean this up, but it felt slightly outside of
the objective. Looks like I need to respin for enetc - I can change
it in v2 if you'd like?
I'd say just keep your patch as is, then I'll send a follow-up that does
the refactor and also adds a comment about why the hashing config is what
it is.