Thread (6 messages) flat view 6 messages, 3 authors, 2025-06-15

Re: [PATCH net-next 1/3] tcp: remove obsolete and unused RFC3517/RFC6675 loss recovery code

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-06-14 20:07:18

On Fri, 13 Jun 2025 19:09:04 -0400 Neal Cardwell wrote:
RACK-TLP loss detection has been enabled as the default loss detection
algorithm for Linux TCP since 2018, in:

 commit b38a51fec1c1 ("tcp: disable RFC6675 loss detection")
Hi! There is a warning here:

net/ipv4/tcp_input.c:2959:6: warning: variable 'fast_rexmit' set but not used [-Wunused-but-set-variable]
 2959 |         int fast_rexmit = 0, flag = *ack_flag;
      |             ^

and another one in patch 2:

net/ipv4/tcp_input.c:3367:29: warning: variable ‘delta’ set but not used [-Wunused-but-set-variable]
 3367 |                         int delta;
      |                             ^~~~~
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help