Thread (36 messages) 36 messages, 5 authors, 2025-06-12

Re: [PATCH net-next 02/14] net: ipv4: ipmr: ipmr_queue_xmit(): Drop local variable `dev'

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: 2025-06-12 10:28:49

On 6/9/25 23:50, Petr Machata wrote:
The variable is used for caching of rt->dst.dev. The netdevice referenced
therein does not change during the scope of validity of that local. At the
same time, the local is only used twice, and each of these uses will end up
in a different function in the following patches, further eliminating any
use the local could have had.

Drop the local altogether and inline the uses.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
  net/ipv4/ipmr.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help