Thread (7 messages) 7 messages, 2 authors, 2025-06-03

Re: [PATCH net-next v2 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-06-03 11:23:27

On 6/3/25 5:51 AM, David J Wilder wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index 1a3d17754c0a..78d41b7b28b5 100644
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -288,13 +288,21 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
 		bond_option_arp_ip_targets_clear(bond);
 		nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) {
 			__be32 target;
+			char target_str[1024 + 1];
This buffer is too big to be placed on the stack. Also please respect
the reverse christmas tree order.

/p
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help