Thread (4 messages) 4 messages, 4 authors, 2025-05-22

Re: [PATCH net-next] eth: bnxt: fix deadlock when xdp is attached or detached

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-05-22 15:50:02
Also in: bpf

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Tue, 20 May 2025 07:11:55 +0000 you wrote:
When xdp is attached or detached, dev->ndo_bpf() is called by
do_setlink(), and it acquires netdev_lock() if needed.
Unlike other drivers, the bnxt driver is protected by netdev_lock while
xdp is attached/detached because it sets dev->request_ops_lock to true.

So, the bnxt_xdp(), that is callback of ->ndo_bpf should not acquire
netdev_lock().
But the xdp_features_{set | clear}_redirect_target() was changed to
acquire netdev_lock() internally.
It causes a deadlock.
To fix this problem, bnxt driver should use
xdp_features_{set | clear}_redirect_target_locked() instead.

[...]
Here is the summary with links:
  - [net-next] eth: bnxt: fix deadlock when xdp is attached or detached
    https://git.kernel.org/netdev/net-next/c/db807e5ef8ee

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help