Re: [Bug] "possible deadlock in rtnl_newlink" in Linux kernel v6.13
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-05-30 00:16:41
Also in:
lkml
On Thu, 29 May 2025 16:50:17 -0700 Joe Damato wrote:
quoted hunk ↗ jump to hunk
@@ -1262,6 +1258,11 @@ static void e1000_remove(struct pci_dev *pdev) bool disable_dev; e1000_down_and_stop(adapter); + + /* Only kill reset task if adapter is not resetting */ + if (!test_bit(__E1000_RESETTING, &adapter->flags)) + cancel_work_sync(&adapter->reset_task); + e1000_release_manageability(adapter); unregister_netdev(netdev);
LGTM, FWIW. For extra points you can move it after the unregister_netdev(), the existing code cancels the work but netdev may still be up and kick it back in..