Thread (11 messages) 11 messages, 3 authors, 2025-05-30

Re: [PATCH net] vmxnet3: correctly report gso type for UDP tunnels

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-05-29 23:33:55
Also in: lkml

On Thu, 29 May 2025 14:55:20 -0700 Ronak Doshi wrote:
On Tue, May 27, 2025 at 9:10 AM Ronak Doshi [off-list ref] wrote:
quoted
On Mon, May 19, 2025 at 12:30 AM Paolo Abeni [off-list ref] wrote:  
quoted
If otherwise the traffic goes into the UDP tunnel rx path, such
processing will set the needed field correctly and no issue could/should
be observed AFAICS.

@Ronak: I think the problem pre-exists this specific patch, but since
you are fixing the relevant offload, I think it should be better to
address the problem now.
 
Can we apply this fix which unblocks one of our customer case and address this
concern as a separate patch as it has been there for a while and it
has a workaround
of enabling tnl segmentation on the redirected interface? I think it
might require quite
some change in vmxnet3 to address this concern and can be done as a
different patch.
Meanwhile, I will raise an internal (broadcom) PR for recreating this
specific issue.
 
Hello Jakub,
Any update on this? Can you help apply this patch?
You put Paolo in the To: field, so I assumed your messages are directed
to him. I'm not entirely sure what you're proposing, to apply this
patch as is? Whether your driver supports segmentation or not - it
should not send mangled skbs into the stack. Maybe send a v2 and
explain next steps in the commit message, less guessing the better..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help