Thread (19 messages) 19 messages, 6 authors, 2025-06-13

Re: [PATCH 1/2] nfsd: use threads array as-is in netlink interface

flat view

From: Simon Horman <horms@kernel.org>
Date: 2025-05-28 17:07:13
Also in: linux-nfs, linux-trace-kernel, lkml

On Tue, May 27, 2025 at 08:12:47PM -0400, Jeff Layton wrote:
The old nfsdfs interface for starting a server with multiple pools
handles the special case of a single entry array passed down from
userland by distributing the threads over every NUMA node.

The netlink control interface however constructs an array of length
nfsd_nrpools() and fills any unprovided slots with 0's. This behavior
defeats the special casing that the old interface relies on.

Change nfsd_nl_threads_set_doit() to pass down the array from userland
as-is.

Fixes: 7f5c330b2620 ("nfsd: allow passing in array of thread counts via netlink")
Reported-by: Mike Snitzer <snitzer@kernel.org>
Closes: https://lore.kernel.org/linux-nfs/aDC-ftnzhJAlwqwh@kernel.org/ (local)
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help