Re: [PATCH v1 3/3] dt-bindings: net: sun8i-emac: Add AC300 EMAC1 nvmem phy selection
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-05-27 06:21:07
Also in:
linux-arm-kernel, linux-devicetree, linux-sunxi, lkml
On Mon, May 26, 2025 at 12:29:36PM GMT, James Hilliard wrote:
quoted hunk ↗ jump to hunk
The Allwinner H616 EMAC1 can be connected to an on-die AC200 or AC300 PHY depending upon the silicon variant. Add a new allwinner,sun50i-h616-emac1 compatible and example, support for the allwinner,sun50i-h616-emac1 will be added later on. Add nvmem-cells and nvmem-cell-names properties for the ac300 efuse based phy selection. Signed-off-by: James Hilliard <redacted> --- .../net/allwinner,sun8i-a83t-emac.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+)diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml index 7fe0352dff0f..b6bf1718dba1 100644 --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml@@ -18,6 +18,7 @@ properties: - const: allwinner,sun8i-r40-gmac - const: allwinner,sun8i-v3s-emac - const: allwinner,sun50i-a64-emac + - const: allwinner,sun50i-h616-emac1 - items: - enum: - allwinner,sun20i-d1-emac@@ -28,6 +29,14 @@ properties: reg: maxItems: 1 + nvmem-cells: + maxItems: 1 + description: NVMEM cell with the ac300 efuse. + + nvmem-cell-names: + items: + - const: ac300 + interrupts: maxItems: 1@@ -321,4 +330,37 @@ examples: }; }; + - | + ethernet@5030000 { + compatible = "allwinner,sun50i-h616-emac1"; + reg = <0x05030000 0x10000>;
No need for new example for every soc. But if you ever decide to add new example, it must work. Please test your patches prior to sending them. Best regards, Krzysztof