Thread (4 messages) 4 messages, 4 authors, 2025-05-28

Re: [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex()

From: Yevgeny Kliteynik <hidden>
Date: 2025-05-25 09:35:04
Also in: kernel-janitors, linux-rdma, lkml

On 23-May-25 19:00, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
This was intended to be negative -ENOMEM but the '-' character was left
off accidentally.  This typo doesn't affect runtime because the caller
treats all non-zero returns the same.

Fixes: 17e0accac577 ("net/mlx5: HWS, support complex matchers")
Signed-off-by: Dan Carpenter <redacted>
---
  .../net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c  | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
index 5d30c5b094fc..70768953a4f6 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
@@ -1188,7 +1188,7 @@ int mlx5hws_bwc_rule_create_complex(struct mlx5hws_bwc_rule *bwc_rule,
  			      GFP_KERNEL);
  	if (unlikely(!match_buf_2)) {
  		mlx5hws_err(ctx, "Complex rule: failed allocating match_buf\n");
-		ret = ENOMEM;
+		ret = -ENOMEM;
  		goto hash_node_put;
  	}
  
Reviewed-by: Yevgeny Kliteynik <redacted>

Thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help