On Thu, 2025-05-22 at 16:19 -0700, Saeed Mahameed wrote:

quoted

The kernel_param->tcp_data_split here is the user config, right?
It would be cleaner to not support setting SPLIT_DISABLED.
Nothing requires that, you can support just setting AUTO and
ENABLED.

I think I agree, AUTO might require some extra work on the driver
side to
figure out current internal mode, but it actually makes more sense
than
just doing "UNKNOWN", UKNOWN here means that HW GRO needs to be
enabled
when disabling TCP HDR split, and we still don't know if that will
work..

Cosmin will you look into this ? 

Yes, I will address all comments from this round by the next
submission.

Cosmin.