Thread (13 messages) 13 messages, 2 authors, 2025-05-21

Re: [PATCH net-next v5 4/5] vsock/test: Introduce enable_so_linger() helper

From: Michal Luczaj <hidden>
Date: 2025-05-21 23:08:21
Also in: kvm, lkml, virtualization

On 5/21/25 16:41, Stefano Garzarella wrote:
On Wed, May 21, 2025 at 12:55:22AM +0200, Michal Luczaj wrote:
quoted
...
static void test_stream_linger_client(const struct test_opts *opts)
{
-	struct linger optval = {
-		.l_onoff = 1,
-		.l_linger = 1
So, we are changing the timeout from 1 to 5, right?
Should we mention in the commit description?
Yup, we do, but the value (as long as it's positive) is meaningless in the
context of this test. That's way I didn't bother. But since
enable_so_linger() is gaining @timeout, I'll pass the original `1` to keep
things as they are.

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help