Re: [PATCH net-next V10 2/6] selftest: netdevsim: Add devlink rate tc-bw test

On 21/05/2025 1:59, Jakub Kicinski wrote:

On Tue, 20 May 2025 21:38:03 +0300 Tariq Toukan wrote:

quoted

Test verifies that netdevsim correctly implements devlink ops callbacks
that set tc-bw on leaf or node rate object.

Please add a test that can actually validate a NIC HW.
The test probably needs to be in Python to use a remote endpoint,
and should live under tools/testing/../drivers/net/hw

We had a long conversation about what we expect from the API
vs how your HW works. One of the test cases should confirm
the expected behavior, IOW fail on mlx5. Which is fine,
unlikely that any NIC will have 100% compliance. But at
least we will be documenting the expectations.

Working on this. Let me know if the netdevsim selftest should stay alongside the hardware tests, or be removed.

Thanks!