Re: [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration

on 2025/5/20 9:14, Wentao Liang wrote:

quoted

Are there any real functional problems?

quoted

Would you please tell me your test cases? I'm going to try to reproduce the problem.

Hi,

I found this problem by static analysis and manual auditing. I believe there should be add a check just like the other call of hclge_set_vlan_filter_hw(). If the check is useless, could you please tell me the detailed reason.

Hi Wentao,
 
Thanks for your reply.

I checked the code, and found that the purpose of all two places called hclge_rm_vport_vlan_table() now is just to update the vlan list,
never do clear the vlan entry in hardware. So I prefer to remove the parameter 'is_write_tbl' from hclge_rm_vport_vlan_table(),
and remove the hclge_set_vlan_filter_hw() calling in it.

Thanks,
Jijie Shao

Thanks,

Wentao Liang.