On 5/16/25 12:00 AM, Bobby Eshleman wrote:

+tap_prefix() {
+	sed -e "s/^/${TAP_PREFIX}/"
+}

I think there is no need to the tap prefix to the output you intend to
'comment out', the kselftest infra should already add the tap prefix
mark to each line generated by the test,

+
+tap_output() {
+	if [[ ! -z "$TAP_PREFIX" ]]; then

AFAICS TAP_PREFIX is a not empty string constant, so this function is
always a no op. If so it should be dropped.

Otherwise LGTM, thanks,

Paolo