Re: [net-next PATCH v4 06/11] net: phy: Export some functions

On 5/15/25 04:12, Russell King (Oracle) wrote:

On Wed, May 14, 2025 at 07:57:16PM -0700, Jakub Kicinski wrote:

quoted

On Mon, 12 May 2025 12:10:08 -0400 Sean Anderson wrote:

quoted

Export a few functions so they can be used outside the phy subsystem:

get_phy_c22_id is useful when probing MDIO devices which present a
phy-like interface despite not using the Linux ethernet phy subsystem.

mdio_device_bus_match is useful when creating MDIO devices manually
(e.g. on non-devicetree platforms).

At the moment the only (future) user of these functions selects PHYLIB,
so we do not need fallbacks for when CONFIG_PHYLIB=n.

This one does not apply cleanly.

In any case, we *still* have two competing implementations for PCS
support, and the authors have been asked to work together, but there's
been no sign of that with both authors posting their patch sets within
the last week.

I have commented on the other series with my feedback. You are welcome to
read it and decide if you agree or not.

Plus, I had asked for the patches to be posted as RFC because I'm not
going to have time to review them for a while (you may have noticed a
lack of patches from myself - because I don't have time to post them
as I'm working on stuff directed by my employer.)

I consider my series ready for mainline. I will not mark it RFC because
it's not an RFC.

Sadly, being employed means there will be times that I don't have the
bandwidth to look at mainline stuff.

Then perhaps some of the other netdev maintainers/reviewers could have
a look.

--Sean