quoted hunk ↗ jump to hunk
-----Original Message-----
From: Justin Lai <justinlai0215@realtek.com>
Sent: Friday, April 25, 2025 2:34 PM
To: kuba@kernel.org
Cc: davem@davemloft.net; <redacted>; pabeni@redhat.com;
andrew+netdev@lunn.ch; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; horms@kernel.org; Ping-Ke Shih
[off-list ref]; Larry Chiu [off-list ref]; Justin Lai
[off-list ref]; Joe Damato [off-list ref]
Subject: [PATCH net-next v2] rtase: Use min() instead of min_t()
Use min() instead of min_t() to avoid the possibility of casting to the
wrong type.
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
Reviewed-by: Joe Damato <redacted>
---
v1 -> v2:
- Remove the Fixes tag.
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c
b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 6251548d50ff..8c902eaeb5ec 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -1983,7 +1983,7 @@ static u16 rtase_calc_time_mitigation(u32 time_us)
u8 msb, time_count, time_unit;
u16 int_miti;
- time_us = min_t(int, time_us, RTASE_MITI_MAX_TIME);
+ time_us = min(time_us, RTASE_MITI_MAX_TIME);
msb = fls(time_us);
if (msb >= RTASE_MITI_COUNT_BIT_NUM) {@@ -2005,7 +2005,7 @@ static u16 rtase_calc_packet_num_mitigation(u16
pkt_num)
u8 msb, pkt_num_count, pkt_num_unit;
u16 int_miti;
- pkt_num = min_t(int, pkt_num, RTASE_MITI_MAX_PKT_NUM);
+ pkt_num = min(pkt_num, RTASE_MITI_MAX_PKT_NUM);
if (pkt_num > 60) {
pkt_num_unit = RTASE_MITI_MAX_PKT_NUM_IDX;
--
2.34.1
Hi reviewers,
I apologize for the interruption, I would like to ask why this patch is
rejected on patchwork.
Justin