Re: [net-next PATCH v10 7/7] rust: net::phy sync with match_phy_device C changes

From
Benno Lossin <lossin@kernel.org>
Date
2025-05-15 12:01:38
Also in
linux-devicetree, lkml, rust-for-linux
Reply to
Christian Marangi, 2025-05-15
On Thu May 15, 2025 at 1:51 PM CEST, Christian Marangi wrote:
On Thu, May 15, 2025 at 01:49:35PM +0200, Benno Lossin wrote:
quoted
On Thu May 15, 2025 at 1:27 PM CEST, Christian Marangi wrote:
quoted
Sync match_phy_device callback wrapper in net:phy rust with the C
changes where match_phy_device also provide the passed PHY driver.

As explained in the C commit, this is useful for match_phy_device to
access the PHY ID defined in the PHY driver permitting more generalized
functions.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 rust/kernel/net/phy.rs | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)
You probably should do this in the same commit as the C changes,
otherwise the in-between commits will error.
You are right, I will fix this in v11 but I would really want to know if
the Rust changes are correct. It's not my main language so it's all
discovering new stuff :D
No worries :) I have lost some context on the PHY Rust bindings, so
Fujita will probably have to review it, but if I find the time, I'll
take a look.

---
Cheers,
Benno
Thread (28 messages) 28 messages, 4 authors, last reply 2025-05-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help