Thread (7 messages) 7 messages, 2 authors, 2025-05-13

Re: [PATCH net-next 2/2] vsock/test: check also expected errno on sigpipe test

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2025-05-13 13:50:03
Also in: lkml, virtualization

On Tue, May 13, 2025 at 12:41:17PM +0200, Paolo Abeni wrote:
On 5/8/25 4:20 PM, Stefano Garzarella wrote:
quoted
diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c
index 7de870dee1cf..533d9463a297 100644
--- a/tools/testing/vsock/vsock_test.c
+++ b/tools/testing/vsock/vsock_test.c
@@ -1074,9 +1074,13 @@ static void test_stream_check_sigpipe(int fd)
 	do {
 		res = send(fd, "A", 1, 0);
 		timeout_check("send");
-	} while (res != -1);
+	} while (res != -1 && errno == EINTR);
I'm low on coffee, but should the above condition be:

	res != -1 || errno == EINTR

instead?
Ooops, copy & paste where we waited successful send().
Same thing below.
I'll fix both!

Thanks,
Stefano
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help