Re: [PATCH net-next v10 02/13] net: pse-pd: Add support for reporting events

On Thu, 8 May 2025 20:10:41 -0700
Jakub Kicinski [off-list ref] wrote:

On Tue, 06 May 2025 11:38:34 +0200 Kory Maincent wrote:

quoted

diff --git a/Documentation/netlink/specs/ethtool.yaml

b/Documentation/netlink/specs/ethtool.yaml index c650cd3dcb80..fbfd293987c1
100644 --- a/Documentation/netlink/specs/ethtool.yaml

+++ b/Documentation/netlink/specs/ethtool.yaml

@@ -98,6 +98,12 @@ definitions:
     name: tcp-data-split
     type: enum
     entries: [ unknown, disabled, enabled ]
+  -
+    name: pse-events
+    type: flags
+    name-prefix: ethtool-pse-event-
+    header: linux/ethtool.h
+    entries: [ over-current, over-temp ]  

please change this enum similarly to what I suggested on the hwts
source patch

Ok.
 

quoted

 attribute-sets:
   -

@@ -1528,6 +1534,18 @@ attribute-sets:
         name: hwtstamp-flags
         type: nest
         nested-attributes: bitset
+  -
+    name: pse-ntf
+    attr-cnt-name: __ethtool-a-pse-ntf-cnt  

please use -- instead of underscores

All the other attributes are using underscore in this property.
Are you sure about this?

quoted

+			phydev = psec->attached_phydev;
+			if (phydev->attached_dev) {
+				netdev = phydev->attached_dev;
+				netdev_hold(netdev, tracker, GFP_ATOMIC);  

GFP_KERNEL ?

Oops indeed, small copy paste mistake.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com