Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management

From
Carolina Jubran <hidden>
Date
2025-05-11 06:44:05
Also in
linux-doc, linux-rdma, lkml
Reply to
Jakub Kicinski, 2025-05-09

On 09/05/2025 18:16, Jakub Kicinski wrote:
On Fri, 9 May 2025 08:43:05 +0300 Tariq Toukan wrote:
quoted
+  -
+    name:  devlink-rate-tc-index-max
+    header: uapi/linux/devlink.h
+    type: const
+    value: 7
Ugh, still wrong, the user space headers don't have uAPI in the path
when installed. They go to /usr/include/linux/$name.h
But for defines "local" to the family you don't have to specify header:
at all, just drop it.

And please do build tests the next version:

	make -C tools/net/ynl/ W=1 -j

I'm going to also give you a hint that my next complaint will be that
there are no selftests in this series, and it extends uAPI.
Noted, working on this. Thanks for the guidance!
Thread (10 messages) 10 messages, 5 authors, last reply 2025-05-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help