Re: [PATCH net] net: qede: Initialize qede_ll_ops with designated initializer

From
Kees Cook <kees@kernel.org>
Date
2025-05-08 00:58:29
Also in
lkml, llvm, stable
Reply to
Nathan Chancellor, 2025-05-07

On May 7, 2025 1:47:45 PM PDT, Nathan Chancellor [off-list ref] wrote:
After a recent change [1] in clang's randstruct implementation to
randomize structures that only contain function pointers, there is an
error because qede_ll_ops get randomized but does not use a designated
initializer for the first member:

 drivers/net/ethernet/qlogic/qede/qede_main.c:206:2: error: a randomized struct can only be initialized with a designated initializer
   206 |         {
       |         ^

Explicitly initialize the common member using a designated initializer
to fix the build.

Cc: <redacted>
Fixes: 035f7f87b729 ("randstruct: Enable Clang support")
Link: https://github.com/llvm/llvm-project/commit/04364fb888eea6db9811510607bed4b200bcb082 [1]
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-
Oops, I missed this one with its 1-character different filename. 😅

Reviewed-by: Kees Cook <kees@kernel.org>


quoted hunk ↗ jump to hunk
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 99df00c30b8c..b5d744d2586f 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -203,7 +203,7 @@ static struct pci_driver qede_pci_driver = {
};

static struct qed_eth_cb_ops qede_ll_ops = {
-	{
+	.common = {
#ifdef CONFIG_RFS_ACCEL
		.arfs_filter_op = qede_arfs_filter_op,
#endif

---
base-commit: 9540984da649d46f699c47f28c68bbd3c9d99e4c
change-id: 20250507-qede-fix-clang-randstruct-13d8c593cb58

Best regards,
-- 
Kees Cook
Thread (3 messages) 3 messages, 3 authors, last reply 2025-05-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help