Re: [PATCH v11 net-next 0/8] PHC support in ENA driver
From: Jiri Pirko <jiri@resnulli.us>
Date: 2025-05-26 09:53:19
Mon, May 26, 2025 at 08:09:10AM +0200, darinzon@amazon.com wrote:
Changes in v11 - Change PHC enablement devlink parameter to be generic instead of device specific Changes in v10 (https://lore.kernel.org/netdev/20250522134839.1336-1-darinzon@amazon.com/ (local)): - Remove error checks for debugfs calls Changes in v9 (https://lore.kernel.org/netdev/20250521114254.369-1-darinzon@amazon.com/ (local)): - Use devlink instead of sysfs for PHC enablement - Use debugfs instead of sysfs for PHC stats - Add PHC error flags and break down phc_err into two errors - Various style changes Changes in v8 (https://lore.kernel.org/netdev/20250304190504.3743-1-darinzon@amazon.com/ (local)): - Create a sysfs entry for each PHC stat Changes in v7 (https://lore.kernel.org/netdev/20250218183948.757-1-darinzon@amazon.com/ (local)): - Move PHC stats to sysfs - Add information about PHC enablement - Remove unrelated style changes Changes in v6 (https://lore.kernel.org/netdev/20250206141538.549-1-darinzon@amazon.com/ (local)): - Remove PHC error bound Changes in v5 (https://lore.kernel.org/netdev/20250122102040.752-1-darinzon@amazon.com/ (local)): - Add PHC error bound - Add PHC enablement and error bound retrieval through sysfs Changes in v4 (https://lore.kernel.org/netdev/20241114095930.200-1-darinzon@amazon.com/ (local)): - Minor documentation change (resolution instead of accuracy) Changes in v3 (https://lore.kernel.org/netdev/20241103113140.275-1-darinzon@amazon.com/ (local)): - Resolve a compilation error Changes in v2 (https://lore.kernel.org/netdev/20241031085245.18146-1-darinzon@amazon.com/ (local)): - CCd PTP maintainer - Fixed style issues - Fixed documentation warning v1 (https://lore.kernel.org/netdev/20241021052011.591-1-darinzon@amazon.com/ (local)) This patchset adds the support for PHC (PTP Hardware Clock) in the ENA driver. The documentation part of the patchset includes additional information, including statistics, utilization and invocation examples through the testptp utility. David Arinzon (8): net: ena: Add PHC support in the ENA driver net: ena: PHC silent reset net: ena: Add device reload capability through devlink devlink: Add new "enable_phc" generic device param net: ena: Control PHC enable through devlink net: ena: Add debugfs support to the ENA driver net: ena: View PHC stats using debugfs net: ena: Add PHC documentation
Could you please add very simple devlink_port instance of flavour PHYSICAL and link it with netdev? Having devlink instance without the port related to the netdev looks a bit odd. Thanks!