Thread (37 messages) 37 messages, 3 authors, 2025-06-22

Re: [BUG] net/sched: Soft Lockup/Task Hang and OOM Loop in netem_dequeue

From: William Liu <hidden>
Date: 2025-05-24 20:09:31

On Saturday, May 24th, 2025 at 1:07 PM, Jamal Hadi Salim [off-list ref] wrote:
"count == 0" seems to be only needed for the loss when a drop decision is made.
Slight tangent: Looking at init() the setup does allow for both to be
on (i.e could be "and" not just "or" as you state above). It feels
sensible to me that if the loss function decided the packet is to be
dropped then that would override the duplication.
This makes perfect sense to me.

By that, I agree that the count variable is not necessary. However, I think it's good to introduce a duplicated boolean instead for readablity's sake, instead of merging all the logic into nest_level. I will get a formal patch set ready sometime soon to address the bug and the other behavioral quirks we found here. 

Thank you for the help so far!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help