Thread (7 messages) 7 messages, 3 authors, 2025-05-30

RE: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to 'hashcfg' for clarity

From: Romanowski, Rafal <hidden>
Date: 2025-05-22 18:16:45
Also in: intel-wired-lan

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Jacob
Keller
Sent: Monday, May 5, 2025 10:14 PM
To: Intel Wired LAN <redacted>; Nguyen, Anthony L
[off-list ref]; netdev [off-list ref]
Cc: Keller, Jacob E <jacob.e.keller@intel.com>; Kitszel, Przemyslaw
[off-list ref]; Loktionov, Aleksandr
[off-list ref]; Simon Horman [off-list ref]
Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to
'hashcfg' for clarity

i40e, ice, and iAVF all use 'hena' as a shorthand for the "hash enable"
configuration. This comes originally from the X710 datasheet 'xxQF_HENA'
registers. In the context of the registers the meaning is fairly clear.

However, on its own, hena is a weird name that can be more difficult to
understand. This is especially true in ice. The E810 hardware doesn't even have
registers with HENA in the name.

Replace the shorthand 'hena' with 'hashcfg'. This makes it clear the variables deal
with the Hash configuration, not just a single boolean on/off for all hashing.

Do not update the register names. These come directly from the datasheet for
X710 and X722, and it is more important that the names can be searched.

Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Aleksandr Loktionov <redacted>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Tested-by: Rafal Romanowski <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help