Re: [PATCH v10 net-next 4/8] net: ena: Control PHC enable through devlink

Thu, May 22, 2025 at 04:22:21PM +0200, darinzon@amazon.com wrote:

quoted

[...]

quoted

+enum ena_devlink_param_id {
+      ENA_DEVLINK_PARAM_ID_BASE =

DEVLINK_PARAM_GENERIC_ID_MAX,

quoted

+      ENA_DEVLINK_PARAM_ID_PHC_ENABLE,

What exactly is driver/vendor specific about this? Sounds quite generic to
me.

Can you please clarify the question?
If you refer to the need of ENA_DEVLINK_PARAM_ID_PHC_ENABLE, it was discussed as part of patchset v8 in https://lore.kernel.org/netdev/20250304190504.3743-6-darinzon@amazon.com/ (local)
More specifically in https://lore.kernel.org/netdev/55f9df6241d052a91dfde950af04c70969ea28b2.camel@infradead.org/ (local)

Could you please read "Generic configuration parameters" section of
Documentation/networking/devlink/devlink-params.rst? Perhaps that would
help. So basically my question is, why your new param can't go in that
list?