Thread (13 messages) 13 messages, 2 authors, 2025-05-22

RE: [PATCH v9 net-next 5/8] net: ena: Add debugfs support to the ENA driver

From: "Arinzon, David" <darinzon@amazon.com>
Date: 2025-05-22 05:24:38

quoted
+void ena_debugfs_init(struct net_device *dev) {
+     struct ena_adapter *adapter = netdev_priv(dev);
+
+     adapter->debugfs_base =
+             debugfs_create_dir(dev_name(&adapter->pdev->dev), NULL);
+     if (IS_ERR(adapter->debugfs_base))
+             netdev_err(dev, "Failed to create debugfs dir\n");
Don't check return codes from debugfs_ calls. It does not matter if it fails, it is
just debug, and all debugfs_ calls are happy to take a NULL pointer,
ERR_PTR() etc.

        Andrew
Thank you for the feedback.
We were looking to get a failure indication and not continue creating the rest of the nodes (patch 6/8).
Will make the changes in the patches and send a v10.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help