On 13/05/2025 09:53, Paolo Abeni wrote:

On 5/9/25 4:26 PM, Antonio Quartulli wrote:

quoted

diff --git a/drivers/net/ovpn/peer.c b/drivers/net/ovpn/peer.c
index 24eb9d81429e..a1fd27b9c038 100644
--- a/drivers/net/ovpn/peer.c
+++ b/drivers/net/ovpn/peer.c

@@ -258,7 +258,7 @@ void ovpn_peer_endpoints_update(struct ovpn_peer *peer, struct sk_buff *skb)
  		 */
  		if (unlikely(!ipv6_addr_equal(&bind->local.ipv6,
  					      &ipv6_hdr(skb)->daddr))) {
-			net_dbg_ratelimited("%s: learning local IPv6 for peer %d (%pI6c -> %pI6c\n",
+			net_dbg_ratelimited("%s: learning local IPv6 for peer %d (%pI6c -> %pI6c)\n",
  					    netdev_name(peer->ovpn->dev),
  					    peer->id, &bind->local.ipv6,
  					    &ipv6_hdr(skb)->daddr);

Since you have to repost it's better to move this chunk to a separate
patch, as it's unrelated to the previous one - or at very least mention
it explicitly in the commit message.

Yeah, the line:
"While at it, add a missing parenthesis in another debugging
message."

was too vague :)

I'll make it more explicit.

Regards,

/P

-- 
Antonio Quartulli
OpenVPN Inc.