Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-03-31 14:30:13
Also in:
intel-wired-lan, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-03-31 14:30:13
Also in:
intel-wired-lan, lkml
From a technical perspective, your patch looks correct. However, if the checksum validation is skipped, there is no way to distinguish between the simple checksum error described above, and actual NVM corruption, which may result in loss of functionality and undefined behavior. This means, that if there is any functional issue with the network adapter on a given system, while checksum validation was suspended by the user, we will not be able to offer support
We have a similar issue with SFP, which contain a checksum. But a few vendors are lazy, they set a serial number and don't recalculate the checksum. We handle this by adding quirks. We know which vendors/products have FUBAR checksums, and allow them to be used when the checksum is FUBAR. You could do something similar here, add a list of vendors with known FUBAR checksums and allow them to be used, but taint the kernel, and print a warming that the device is unsupported because the vendor messed up the CRC. Andrew