On Thu, Mar 27, 2025 at 11:07:16AM +0000, Russell King (Oracle) wrote:
On Thu, Mar 27, 2025 at 12:35:01AM +0100, Christian Marangi wrote:
quoted
Pass PHY driver pointer to .match_phy_device OP in addition to phydev.
Having access to the PHY driver struct might be useful to check the
PHY ID of the driver is being matched for in case the PHY ID scanned in
the phydev is not consistent.
A scenario for this is a PHY that change PHY ID after a firmware is
loaded, in such case, the PHY ID stored in PHY device struct is not
valid anymore and PHY will manually scan the ID in the match_phy_device
function.
Having the PHY driver info is also useful for those PHY driver that
implement multiple simple .match_phy_device OP to match specific MMD PHY
ID. With this extra info if the parsing logic is the same, the matching
function can be generalized by using the phy_id in the PHY driver
instead of hardcoding.
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Reviewed-by: Russell King (Oracle) <redacted>
Please also update the email address in the suggested-by to match the
one in my reviewed-by for the next resend.
Thanks!
kernel test robot made me aware that this cause error with
nxp-c45-tja11xx. I was on an old net-next branch and didn't notice the
""recent"" changes to macsec support. I'm updating this and keeping the
reviewed-by tag, hope it's OK.
Also adding the simplify commit as suggested that recive the
match_phy_device.
--
Ansuel