Re: [PATCH net-next 06/13] net: macb: simplify macb_probe() code touching match data

From
Andrew Lunn <andrew@lunn.ch>
Date
2025-03-21 20:57:34
Also in
linux-devicetree, linux-mips, linux-riscv, lkml
Reply to
Théo Lebrun, 2025-03-21
On Fri, Mar 21, 2025 at 08:09:37PM +0100, Théo Lebrun wrote:
Remove local variables clk_init and init. Those function pointers are
always equivalent to macb_config->clk_init and macb_config->init.

Also remove NULL checks on macb_config as it is always valid:
 - either it is its default value &default_gem_config,
 - or it got overridden using match data.
I probably would of made this two patches. But otherwise it looks O.K.

  Andrew
Thread (38 messages) 38 messages, 6 authors, last reply 2025-03-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help