Thread (9 messages) 9 messages, 4 authors, 2025-03-17

Re: [PATCH 7/9] net: phy: fixed_phy: transition to the faux device interface

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-03-17 12:29:42
Also in: lkml

On Mon, Mar 17, 2025 at 10:13:19AM +0000, Sudeep Holla wrote:
The net fixed phy driver does not require the creation of a platform
device. Originally, this approach was chosen for simplicity when the
driver was first implemented.

With the introduction of the lightweight faux device interface, we now
have a more appropriate alternative. Migrate the driver to utilize the
faux bus, given that the platform device it previously created was not
a real one anyway. This will simplify the code, reducing its footprint
while maintaining functionality.

Cc: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Sudeep Holla <redacted>
---
 drivers/net/phy/fixed_phy.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
8 insertions, 8 deletions. How does this reduce its footprint?

Seems like pointless churn to me. Unless there is a real advantage to
faux bus you are not enumerating in your commit message.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help