Thread (5 messages) 5 messages, 5 authors, 2025-03-12

Re: [PATCH net-next] net: revert to lockless TC_SETUP_BLOCK and TC_SETUP_FT

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-03-12 20:19:56
Also in: linux-doc, lkml, netfilter-devel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Fri,  7 Mar 2025 20:47:26 -0800 you wrote:
There is a couple of places from which we can arrive to ndo_setup_tc
with TC_SETUP_BLOCK/TC_SETUP_FT:
- netlink
- netlink notifier
- netdev notifier

Locking netdev too deep in this call chain seems to be problematic
(especially assuming some/all of the call_netdevice_notifiers
NETDEV_UNREGISTER) might soon be running with the instance lock).
Revert to lockless ndo_setup_tc for TC_SETUP_BLOCK/TC_SETUP_FT. NFT
framework already takes care of most of the locking. Document
the assumptions.

[...]
Here is the summary with links:
  - [net-next] net: revert to lockless TC_SETUP_BLOCK and TC_SETUP_FT
    https://git.kernel.org/netdev/net-next/c/0a13c1e0a449

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help