Thread (3 messages) 3 messages, 3 authors, 2025-03-12

Re: [PATCH] sctp: handle error of sctp_sf_heartbeat() in sctp_sf_do_asconf()

From: Markus Elfring <hidden>
Date: 2025-03-12 12:33:28
Also in: linux-sctp, lkml

In sctp_sf_do_asconf(), SCTP_DISPOSITION_NOMEM error code returned
from sctp_sf_heartbeat() represent a failure of sent HEARTBEAT. The
                                                       heartbeat?

Would the error predicate “return value != SCTP_DISPOSITION_CONSUME” be safer?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/net/sctp/sm.h#L43

return value of sctp_sf_heartbeat() needs to be checked and propagates
to caller function.
Will imperative wordings be more desirable for such a change description?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc6#n94

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help