Thread (23 messages) 23 messages, 7 authors, 2025-03-12

Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

From: NeilBrown <hidden>
Date: 2025-03-11 22:55:30
Also in: kvm, linux-btrfs, linux-mm, linux-nfs, linux-xfs, lkml, virtualization

On Mon, 10 Mar 2025, Gao Xiang wrote:
  - Your new api covers narrow cases compared to the existing
    api, although all in-tree callers may be converted
    properly, but it increases mental burden of all users.
    And maybe complicate future potential users again which
    really have to "check NULL elements in the middle of page
    bulk allocating" again.
I think that the current API adds a mental burden for most users.  For
most users, their code would be much cleaner if the interface accepted
an uninitialised array with length, and were told how many pages had
been stored in that array.

A (very) few users benefit from the complexity.  So having two
interfaces, one simple and one full-featured, makes sense.

Thanks,
NeilBrown
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help