Re: [PATCH RESEND] tipc: Reduce scope for the variable“fdefq” in tipc_link_tnl_prepare()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-03-05 02:50:49
Also in:
cocci, kernel-janitors, lkml
On Sun, 2 Mar 2025 21:30:27 +0100 Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Thu, 13 Apr 2023 17:00:11 +0200
The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the function “tipc_link_tnl_prepare”.
Thus avoid the risk for undefined behaviour by moving the definition
for the local variable “fdefq” into an if branch at the end.
This issue was detected by using the Coccinelle software.
Fixes: 58ee86b8c775 ("tipc: adapt link failover for new Gap-ACK algorithm")
Signed-off-by: Markus Elfring <redacted>Applied without the Fixes tag, thanks.