Re: [PATCH net-next v2 06/10] net: usb: lan78xx: Improve error handling in EEPROM and OTP operations
flat view
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2025-03-04 05:40:34
Also in:
lkml
On Mon, Mar 03, 2025 at 06:02:23PM +0000, Mark Brown wrote:
On Wed, Dec 04, 2024 at 09:41:38AM +0100, Oleksij Rempel wrote:quoted
Refine error handling in EEPROM and OTP read/write functions by: - Return error values immediately upon detection. - Avoid overwriting correct error codes with `-EIO`. - Preserve initial error codes as they were appropriate for specific failures. - Use `-ETIMEDOUT` for timeout conditions instead of `-EIO`.This patch (which is in Linus' tree) appears to break booting with a NFS root filesystem on Raspberry Pi 3B+. There appears to be at least no incoming traffic seen on the device, I've not checked if there's anything outgoing: [ 19.234086] usb 1-1.1.1: new high-speed USB device number 6 using dwc2 [ 19.394134] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl 0x50 [ 19.710839] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: renamed from eth0 Device /sys/class/net/enxb827ebea22ac found done. Begin: Waiting up to 180 secs for any network device to become available ... done. IP-Config: enxb827ebea22ac hardware address b8:27:eb:ea:22:ac mt[ 20.663606] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: Link is Down u 1500 DHCP [ 22.708103] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: Link is Up - 1Gbps/Full - flow control off IP-Config: no response after 2 secs - giving up The link did look like it was up on the switch. Full log: https://lava.sirena.org.uk/scheduler/job/1158809#L965
Thank you! I'm investigating it. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |