Re: [PATCH net-next v6 1/8] net: add get_netmem/put_netmem support

From
Jakub Kicinski <kuba@kernel.org>
Date
2025-03-01 00:38:48
Also in
kvm, linux-doc, linux-kselftest, lkml, virtualization
Reply to
Mina Almasry, 2025-02-27
On Thu, 27 Feb 2025 04:12:02 +0000 Mina Almasry wrote:
quoted hunk ↗ jump to hunk
 static inline void __skb_frag_ref(skb_frag_t *frag)
 {
-	get_page(skb_frag_page(frag));
+	get_netmem(skb_frag_netmem(frag));
 }
Silently handling types of memory the caller may not be expecting
always worries me. Why do we need this? 

In general, I'm surprised by the lack of bug reports for devmem.
Can you think of any way we could expose this more to syzbot?
First thing that comes to mind is a simple hack in netdevsim,
to make it insert a netmem handle (allocated locally, not a real
memory provider), every N packets (controllable via debugfs).
Would that work?
Thread (25 messages) 25 messages, 6 authors, last reply 2025-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help