Thread (3 messages) 3 messages, 2 authors, 2025-03-31

Re: [PATCH v1 net] rtnetlink: Use register_pernet_subsys() in rtnl_net_debug_init().

From: Kuniyuki Iwashima <hidden>
Date: 2025-03-31 18:26:05

From: Simon Horman <horms@kernel.org>
Date: Mon, 31 Mar 2025 16:48:49 +0100
On Fri, Mar 28, 2025 at 03:04:48PM -0700, Kuniyuki Iwashima wrote:
quoted
rtnl_net_debug_init() registers rtnl_net_debug_net_ops by
register_pernet_device() but calls unregister_pernet_subsys()
in case register_netdevice_notifier() fails.

It corrupts pernet_list because first_device is not updated
in unregister_pernet_device().
Hi Iwashima-san,

Maybe I am confused, but should the above line refer to
unregister_pernet_subsys()?
Ah, exactly :)

And perhaps it would be yet clearer to say something like:

It corrupts pernet_list because first_device is not updated
in register_pernet_device() but not unregister_pernet_subsys()?
Will rewrite in v2.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help