Re: [PATCH net v2 06/11] netdevsim: add dummy device notifiers
From: Stanislav Fomichev <hidden>
Date: 2025-03-28 15:07:15
From: Stanislav Fomichev <hidden>
Date: 2025-03-28 15:07:15
On 03/27, Kuniyuki Iwashima wrote:
From: Jakub Kicinski <kuba@kernel.org> Date: Thu, 27 Mar 2025 14:46:09 -0700quoted
On Thu, 27 Mar 2025 14:04:06 -0700 Stanislav Fomichev wrote:quoted
quoted
Can we register empty notifiers in nsim (just to make sure it has a callback) but do the validation in rtnl_net_debug.c I guess we'd need to transform rtnl_net_debug.c a little, make it less rtnl specific, compile under DEBUG_NET and ifdef out the small rtnl parts?s/rtnl_net_debug.c/notifiers_debug.c/ + DEBUG_NET? Or I can keep the name and only do the DEBUG_NET part.I was thinking lock or locking as in net/core/lock_debug.cMaybe lock.c (or netdev_lock.c like netdev_lock.h) and move all locking stuff (netdev_lock_type[], netdev_lock_pos(), etc) there later + ifdef where necessary ?
That might work as well, but will require move moving. Maybe I can start with s/rtnl_net_debug.c/lock.c/ and the we can move the other stuff separately?