Re: [PATCH v10 nf-next 1/3] net: pppoe: avoid zero-length arrays in struct pppoe_hdr

From
Eric Woudstra <hidden>
Date
2025-03-25 06:46:54
Also in
linux-hardening, netfilter-devel
Reply to
Simon Horman, 2025-03-23

On 3/23/25 5:48 PM, Simon Horman wrote:
On Sat, Mar 15, 2025 at 08:59:08PM +0100, Eric Woudstra wrote:
quoted
Jakub Kicinski suggested following patch:

W=1 C=1 GCC build gives us:

net/bridge/netfilter/nf_conntrack_bridge.c: note: in included file (through
../include/linux/if_pppox.h, ../include/uapi/linux/netfilter_bridge.h,
../include/linux/netfilter_bridge.h): include/uapi/linux/if_pppox.h:
153:29: warning: array of flexible structures

It doesn't like that hdr has a zero-length array which overlaps proto.
The kernel code doesn't currently need those arrays.

PPPoE connection is functional after applying this patch.

Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>

---

Split from patch-set: bridge-fastpath and related improvements v9

Signed-off-by: Eric Woudstra <redacted>
Hi Eric,

Perhaps this is due to tooling, but your Signed-off-by line should
appear immediately after the Reviewed-by line. No blank line in between.

And, in particular, the Signed-off-by line should appear above the (first)
scissors ("---"), as if git am is used to apply your patch then the
commit message will be truncated at that point. Which results
in a commit with no signed-off-by line.

FWIIW, putting the note about splitting the patch-set below the scissors
looks good to me.

...
Thanks, when I noticed it, it was send already. I've changed my script,
so it should not happen anymore.
Thread (8 messages) 8 messages, 3 authors, last reply 2025-03-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help