Thread (11 messages) read the whole thread 11 messages, 4 authors, 2025-03-18

Re: [PATCH net-next 3/7] bnxt_en: Add devlink support for ENABLE_ROCE nvm parameter

From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-03-18 09:22:51

On 3/10/25 7:31 PM, Michael Chan wrote:
quoted hunk ↗ jump to hunk
@@ -1128,6 +1130,32 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
 	return bnxt_hwrm_nvm_req(bp, id, req, &ctx->val);
 }
 
+static int bnxt_dl_roce_validate(struct devlink *dl, u32 id,
+				 union devlink_param_value val,
+				 struct netlink_ext_ack *extack)
+{
+	const struct bnxt_dl_nvm_param nvm_roce_cap = {0, NVM_OFF_RDMA_CAPABLE,
+		BNXT_NVM_SHARED_CFG, 1, 1};
+	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
+	struct hwrm_nvm_get_variable_input *req;
+	union devlink_param_value roce_cap;
+	int rc;
+
+	rc = hwrm_req_init(bp, req, HWRM_NVM_GET_VARIABLE);
+	if (rc)
+		return rc;
Not blocking this series, but I'm wondering: any special reason to not
fill the extack here? Could possibly be a small follow-up.

Thanks,

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help