Thread (8 messages) 8 messages, 3 authors, 2025-03-10

Re: [PATCH net-next 1/3] ipv6: remove leftover ip6 cookie initializer

flat view

From: Eric Dumazet <hidden>
Date: 2025-03-07 10:05:43

On Fri, Mar 7, 2025 at 4:36 AM Willem de Bruijn
[off-list ref] wrote:
From: Willem de Bruijn <willemb@google.com>

As of the blamed commit ipc6.dontfrag is always initialized at the
start of udpv6_sendmsg, by ipcm6_init_sk, to either 0 or 1.

Later checks against -1 are no longer needed and the branches are now
dead code.

The blamed commit had removed those branches. But I had overlooked
this one case.

UDP has both a lockless fast path and a slower path for corked
requests. This branch remained in the fast path.

Fixes: 096208592b09 ("ipv6: replace ipcm6_init calls with ipcm6_init_sk")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help