Thread (28 messages) 28 messages, 7 authors, 2025-06-10
STALE364d

[PATCH 9/9] regulator: scmi: Use of_find_node_by_name_balanced() to find device_node

From: Zhang Zekun <hidden>
Date: 2025-02-07 01:39:58
Also in: arm-scmi, linux-devicetree, linux-media, linuxppc-dev
Subsystem: system control & power/management interface (scpi/scmi) message protocol drivers, the rest, voltage and current regulator framework · Maintainers: Sudeep Holla, Linus Torvalds, Liam Girdwood, Mark Brown

Instead of directly using of_node_get() before of_find_node_by_name()
to balance the refcount of the device_node, using wraper function
of_find_node_by_name_balanced() to make code logic a bit simplier.

Signed-off-by: Zhang Zekun <redacted>
---
 drivers/regulator/scmi-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
index 9df726f10ad1..11f75c13bdf0 100644
--- a/drivers/regulator/scmi-regulator.c
+++ b/drivers/regulator/scmi-regulator.c
@@ -339,8 +339,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)
 	 * plausible SCMI Voltage Domain number, all belonging to this SCMI
 	 * platform instance node (handle->dev->of_node).
 	 */
-	of_node_get(handle->dev->of_node);
-	np = of_find_node_by_name(handle->dev->of_node, "regulators");
+	np = of_find_node_by_name_balanced(handle->dev->of_node, "regulators");
 	for_each_child_of_node_scoped(np, child) {
 		ret = process_scmi_regulator_of_node(sdev, ph, child, rinfo);
 		/* abort on any mem issue */
-- 
2.22.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help