Thread (4 messages) 4 messages, 3 authors, 2025-02-27

Re: [PATCH net-next] net: ethernet: ti: cpsw_new: populate netdev of_node

From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Date: 2025-02-27 14:18:23
Also in: linux-omap, lkml

Hi Andrew,

On Thu, 2025-02-27 at 14:24 +0100, Andrew Lunn wrote:
On Thu, Feb 27, 2025 at 08:46:46AM +0100, A. Sverdlin wrote:
quoted
From: Alexander Sverdlin <alexander.sverdlin@siemens.com>

So that of_find_net_device_by_node() can find cpsw-nuss ports and other DSA
                                                      ^^^^^

Oops, copy-paste failure here, nuss was for the am65-cpsw-nuss driver,
maybe "-nuss" could be simply deleted from the commit message on "apply"...
quoted
switches can be stacked downstream. Tested in conjunction with KSZ8873.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Consistent with other TI drivers. But it looks like only TI drivers
need this, which suggests they are all doing something wrong, maybe
for legacy reasons.
Well, yes, they re-invent the wheel, mimicking the DSA infrastructure
without using it. CPSW is a switch, as the name suggests, but the
effort has not been spent to bring it to DSA home ;-)

So what happens here actually is, I'm assigning a DT node to "user port"
in DSA terms, and dsa_register_switch() would for sure do it...
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
-- 
Alexander Sverdlin
Siemens AG
www.siemens.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help