Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

From
Michael S. Tsirkin <mst@redhat.com>
Date
2025-02-25 14:21:34
Also in
linux-arm-kernel, lkml, virtualization
Reply to
Simon Horman, 2025-02-25
On Tue, Feb 25, 2025 at 02:12:40PM +0000, Simon Horman wrote:
On Tue, Feb 25, 2025 at 12:28:24PM +0100, Peter Hilber wrote:
quoted
On Mon, Feb 24, 2025 at 05:56:18PM +0000, Simon Horman wrote:
quoted
On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote:

...
quoted
+/**
+ * viortc_ptp_gettimex64() - PTP clock gettimex64 op
+ *
Hi Peter,

Tooling recognises this as a kernel doc, and complains
that there is no documentation present for the function's
parameters: ptp, ts, and sts.

Flagged by W=1 builds.
Thanks, I will change the offending documentation to non kernel-doc. I
was not aware that these warnings are always considered a problem.
Likewise, thanks.

I guess it depends on the subsystem. And perhaps this is fine for virtio.
But for Networking at large the rule of thumb is not to add new warnings.
Nope.
Thread (12 messages) 12 messages, 3 authors, last reply 2025-02-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help