-----Original Message-----
From: Paolo Abeni <pabeni@redhat.com>
Sent: Thursday, February 20, 2025 5:20 PM
To: Sai Krishna Gajula <redacted>; davem@davemloft.net;
edumazet@google.com; kuba@kernel.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; Sunil Kovvuri Goutham [off-list ref];
Geethasowjanya Akula [off-list ref]; Linu Cherian
[off-list ref]; Jerin Jacob [off-list ref]; Hariprasad Kelam
[off-list ref]; Subbaraya Sundeep Bhatta [off-list ref];
andrew+netdev@lunn.ch; kalesh-anakkur.purayil@broadcom.com
Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic
mbox operations and structures

On 2/17/25 9: 52 AM, Sai Krishna wrote: > @@ -2443,6 +2469,18 @@ static
int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, > } > } > > +
ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL); > + if
(!ng_rvu_mbox) 
On 2/17/25 9:52 AM, Sai Krishna wrote:

quoted

@@ -2443,6 +2469,18 @@ static int rvu_mbox_init(struct rvu *rvu, struct

mbox_wq_info *mw,

quoted

 		}
 	}

+	ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL);
+	if (!ng_rvu_mbox) {
+		err = -ENOMEM;
+		goto free_bitmap;
+	}
+
+	rvu->ng_rvu = ng_rvu_mbox

AFAICS rvu->ng_rvu is freed only by rvu_remove(), so it's leaked on the later
error paths.

Ack, will submit v11 with updates.

/P